Update WMAgent deployment to parse MSPILEUP_URL - take2 #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @amaltaro
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deployment updates for WMAgent to go together with dmwm/WMCore#11795
Please do not merge it yet.
@todor-ivanov we need to decide whether:
a) we enforce the new
mspileup_urlparameter, but then it's not backwards compatible.b) we only pass the
mspileup_urlparameter if it's found in the secrets file, but then we might be deploying agents in the future without seeing that the MSPileup endpoint was not configured in the agent.I opted for a) for the moment, but if you prefer, I can change it to b). Please let me know.